Take care deleting variants products

doofinder · Dec 17, 2024 · f8c6286 · f8c6286
1 parent 3385e29
commit f8c6286
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 6 deletions.
diff --git a/Observer/Product/AbstractChangedProductObserver.php b/Observer/Product/AbstractChangedProductObserver.php
@@ -83,10 +83,11 @@ public function execute(Observer $observer)
             try {
                 $product = $observer->getEvent()->getProduct();
                 $operationType = $this->getOperationType();
-
+                $parentProducts = $this->configurableProductType->getParentIdsByChild($product->getId());
+
                 if ($product->getStatus() == Status::STATUS_DISABLED) {
                     $this->setOperationType(ChangedItemInterface::OPERATION_TYPE_DELETE);
-                } elseif (!in_array($product->getVisibility(), $this->visibilityAllowed)){
+                } elseif (!in_array($product->getVisibility(), $this->visibilityAllowed) && count($parentProducts) == 0){
                     $this->setOperationType(ChangedItemInterface::OPERATION_TYPE_DELETE);
                 } elseif ($product->getUpdatedAt() == $product->getCreatedAt() &&
                     $operationType == ChangedItemInterface::OPERATION_TYPE_UPDATE
@@ -99,7 +100,7 @@ public function execute(Observer $observer)
                 }
 
                 if ($product->getStore()->getId() == 0 ||
-                    $this->getOperationType() == ChangedItemInterface::OPERATION_TYPE_DELETE
+                    $operationType == ChangedItemInterface::OPERATION_TYPE_DELETE
                 ) {
                     foreach ($this->storeConfig->getAllStores() as $store) {
                         $this->registerChangedItemStore($product, (int)$store->getId());
@@ -126,7 +127,7 @@ protected function registerChangedItemStore(ProductInterface $product, int $stor
 
         $itemsToInsert = [$itemId];
         $parentProducts = $this->configurableProductType->getParentIdsByChild($itemId);
-        if (count($parentProducts) > 0) {
+        if (count($parentProducts) > 0 && $this->getOperationType() != ChangedItemInterface::OPERATION_TYPE_DELETE) {
             /* When updating a product it's children are also updated, so in this case we include the parentId but don't need to specify the itemId */
             $itemsToInsert = $parentProducts;
         }

diff --git a/composer.json b/composer.json
@@ -1,6 +1,6 @@
 {
     "name": "doofinder/doofinder-magento2",
-    "version": "1.0.2",
+    "version": "1.0.3",
     "description": "Doofinder module for Magento 2",
     "type": "magento2-module",
     "require": {

diff --git a/etc/module.xml b/etc/module.xml
@@ -1,6 +1,6 @@
 <?xml version="1.0"?>
 <config xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:noNamespaceSchemaLocation="urn:magento:framework:Module/etc/module.xsd">
-    <module name="Doofinder_Feed" setup_version="1.0.2">
+    <module name="Doofinder_Feed" setup_version="1.0.3">
         <sequence>
             <module name="Magento_Integration" />
         </sequence>