Try implementing interface #320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofia-doofinder
requested review from
Aitor-Corrales,
davidmolinacano and
brunovesar
brunovesar
approved these changes
May 15, 2024
Aitor-Corrales
approved these changes
May 15, 2024
| @@ -10,12 +10,15 @@ | |||
| use Magento\Catalog\Helper\Image as ImageHelper; | |||
| use Magento\Catalog\Helper\ImageFactory; | |||
| use Magento\Catalog\Model\Product; | |||
| use Magento\Catalog\Model\ProductRepository as ProductRepositoryBase; | |||
There was a problem hiding this comment.
I'd suggest using a factory instead using a factory instead of the repository itself
sofia-doofinder
deleted the
Sofia/issue_backwards_compatibilidy_magento_4_7
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
El PR que nos propuso magento2 instanciando cada una de las instancias que necesitamos en vez de usar el constructor no ha funcionado porque no pasa la validación.
Tras comentarlo en la issue que le abrimos a magento nos han propuesto que implementemos la interfaz en vez de extender la clase: magento/magento2#38669
He estado haciendo pruebas y la indexación funciona, pero no se si esta forma le va a gustar a magento y no lo podemos saber hasta que subamos la versión al validador.