Fix marketplace test issue #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmolinacano
approved these changes
Oct 31, 2024
brunovesar
reviewed
Oct 31, 2024
sofia-doofinder
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A partir de la versión 0.14.9 ha comenzado a fallar la subida de versiones en Magento, al parecer es posible que hayan cambiado algo en el entorno de pruebas de ellos.
El caso es que falla al generar fixtures.
Después de verlo en conjunto todo el equipo, vimos que agregando una columna con nombre skip_entity_id_binding y con llave foránea que hace referencia a catalog_product_entity.entity_id.
Además había que quitar la restricción que no permites adicionar duplicados a la tabla nuestra.
Haciendo las pruebas me percaté que entonces el collection que se usa para procesar el Update on Save, viene con elementos duplicados, por lo cual he introducido un cambio para filtrar esos duplicados a la hora de procesar, pero eliminar todos los elementos como siempre.