Don't index products with invalid visibility #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sofia-doofinder
requested review from
brunovesar,
ogomezba and
davidmolinacano
davidmolinacano
requested changes
Nov 20, 2024
ogomezba
approved these changes
Nov 20, 2024
sofia-doofinder
deleted the
Sofia/support_2997_update_on_save_of_invalid_products
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket related: https://github.com/doofinder/support/issues/2997
Nosotros en la indexación no estamos indexando producto con visibility <= 2 (que significa que no son productos visibles individualmente ni productos que pertenecen sólo al catálogo), si no que tienen que sear searchables (que es visibilidad 3) o searchables, catalog que es visibilidad 4.
Pero en el update on save no estamos excluyendo esos productos, por eso aparecían en el update on save pero se quitaban con la indexación.