Skip to content
This repository has been archived by the owner on Apr 16, 2024. It is now read-only.

Problem with the built-in runner #164

Closed
joalon opened this issue Oct 13, 2021 · 3 comments
Closed

Problem with the built-in runner #164

joalon opened this issue Oct 13, 2021 · 3 comments
Labels
branch: main For stuff regarding to main branch good first issue Good for newcomers priority: medium Medium priority stuff scope: bug Something isn't working

Comments

@joalon
Copy link
Contributor

joalon commented Oct 13, 2021

Hello!

Love the project, really impressed with the work being done!

I'm having some trouble when using the built-in runner. When using a stock doom-nvim config, I enabled the 'runner', 'compiler' and 'terminal' plugins and then try to run a python file using SPC c r and SPC c i. Then I'm getting the errors:

init.lua:7: Doom runner needs toggleterm plugin, please uncomment the 'terminal' entry in your doom_modules.lua
lua/doom/modules/built-in/runner/init.lua:56: attempt to index upvalue 'term' (a nil value)

I tried restarting, then I checked to see the plugin status and saw that toggleterm was installed but not loaded. I think this might be a lazy loading issue due to terminal not being available at the time the local term variable in the built-in runner is set. I'll look into making a fix unless someone is faster/already working on it :)

@NTBBloodbath
Copy link
Collaborator

Hey mate, sorry for the late reply!

I think this is because toggleterm plugin is now called toggleterm.nvim instead of nvim-toggleterm.lua so our conditional to load toggleterm on runner/compiler built-in plugins fails. In theory it should be an easy fix, please let me know if you're going to do it yourself or if you want me to do it :)

Regards

@NTBBloodbath NTBBloodbath added branch: main For stuff regarding to main branch scope: bug Something isn't working good first issue Good for newcomers priority: medium Medium priority stuff labels Oct 13, 2021
@joalon
Copy link
Contributor Author

joalon commented Oct 14, 2021

Wow, you're fast!

Ok, that should be it :) I'll take a look at it and get back to you during the day

@NTBBloodbath
Copy link
Collaborator

Sure thing mate, thanks per reporting this :)

joalon added a commit to joalon/doom-nvim that referenced this issue Oct 14, 2021
joalon added a commit to joalon/doom-nvim that referenced this issue Oct 15, 2021
joalon added a commit to joalon/doom-nvim that referenced this issue Oct 17, 2021
joalon added a commit to joalon/doom-nvim that referenced this issue Oct 17, 2021
…eterm.nvim in the built-in runner and compiler

           Update the toggleterm url in the docs
NTBBloodbath pushed a commit that referenced this issue Oct 17, 2021
…in the built-in runner and compiler

           Update the toggleterm url in the docs
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
branch: main For stuff regarding to main branch good first issue Good for newcomers priority: medium Medium priority stuff scope: bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants