feat(neotree): replace all-the-icons by nerd-icons #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note that I also have similar update for the treemacs extension, but I don't use treemacs and haven't tested at all, so I'm not very confortable doing the MR, unless someone wants to try it out (also, I don't really understand everything I'm doing ;) ) |
forty
force-pushed
the
forty/neotree-nerd-fonts
branch
from
2ad08a0 to
45f7371
Compare
forty
force-pushed
the
forty/neotree-nerd-fonts
branch
from
45f7371 to
e9e8b9b
Compare
forty
force-pushed
the
forty/neotree-nerd-fonts
branch
2 times, most recently
from
462df22 to
47462a0
Compare
forty
force-pushed
the
forty/neotree-nerd-fonts
branch
2 times, most recently
from
9157d3a to
ed64143
Compare
Main caveat is that there is no "nf-oct-file_text" in nerd-icons so "file-text" octicon have been replaced by "nf-oct-file" (so they will appear as generic files rather than text files)
forty
force-pushed
the
forty/neotree-nerd-fonts
branch
from
ed64143 to
f8a640d
Compare
|
@hlissner 👋 sorry for the ping, I broke my Emacs config again because of this pending patch 😅 and I was wondering is there was any interest in merging it, if I should change anything, or not? |
hlissner
added
is:feature
|
Sorry for taking so long to get to this. Thanks for your help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have issues when missing all-the-icons and nerd-icons. It seems that nerd-icons is the new thing, so I updated neotree extension to use it, and it seems to work fine here (both in simple and normal mode)
Related #263