Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tuple Indexing #13

Closed
doonv opened this issue Jan 17, 2024 · 0 comments · Fixed by #15
Closed

Tuple Indexing #13

doonv opened this issue Jan 17, 2024 · 0 comments · Fixed by #15
Labels
A-Builtin-Parser This is related to the Built-in Parser C-Enhancement New feature or request
Milestone
0.1

Comments

@doonv
Copy link
Owner

doonv commented Jan 17, 2024 •
edited
Loading

What problem does this solve or what need does it fill?

You cannot index specific elements in tuples.

What solution would you like?

Add the ability to index specific elements in tuples.

This is a bit difficult due to Expression::Member only taking in identifiers. We would have to split the String type to support more types of indexing. Bevy Reflect's Access type could help with this, but it will be private until bevyengine/bevy#11029 gets merged. So in the meantime we will have to use our own type.
@doonv doonv added C-Enhancement New feature or request A-Builtin-Parser This is related to the Built-in Parser labels Jan 17, 2024
@doonv doonv added this to the 0.1 milestone Jan 17, 2024
@doonv doonv added S-Blocked This cannot more forward until something else changes and removed S-Blocked This cannot more forward until something else changes labels Jan 18, 2024
@doonv doonv mentioned this issue Jan 23, 2024
Merged
@doonv doonv closed this as completed in #15 Jan 27, 2024
doonv added a commit that referenced this issue Jan 27, 2024
@doonv
Tuple Indexing & Improved member expressions (#15)
7fe5d8c 
# Objective

Fix #13

## Solution

Add tuple indexing by allow support for more than identifiers with `Access`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Builtin-Parser This is related to the Built-in Parser C-Enhancement New feature or request
Projects
None yet
Milestone
0.1
Development

Successfully merging a pull request may close this issue.

Tuple Indexing & Improved member expressions doonv/bevy_dev_console
1 participant
@doonv