-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Showing
4 changed files
with
0 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
d6b4ead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I keep getting ActiveModel::MassAssignmentSecurity::Error. I wonder if this is the cause? Can I ask why this was removed?
d6b4ead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The reason is that
attr_accessible
is not available anymore in rails 4 (see this)Are you sure you are getting this error from using Doorkeeper, if so, could you share a gist with relevant code?
d6b4ead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right! Sorry, completely forgot!
Well the error is very unexpected. I added a quick solution for an assertion flow (#249). With my additions
ActiveModel::MassAssignmentSecurity::Error
is raised for every model creation, but when I use the applicake/doorkeeper at master no exceptions are raised at all, even though I didn't modify the models in my pull request.Can you see anything I might have changed in my PR? All the tests pass.
d6b4ead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just cloned your repo and tests pass.
d6b4ead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, i added a few tests to check if the assertion flow works, but once i include my version
tsov/doorkeeper
at master to my rails project (version 3.2.13), the exceptions are raised. It seems like such an unexpected error. Is it supposed to raise the mass assignment security error in rails 3?