Authorization code must be short lived and single use #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was creating the access token with wrong client id
According to specs, access grants must be short lived and single use. This means tha after the access token is issued for a specific grant, the grant must be revoked and cannot be used again. http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-10.5 This commit upgrades all migration files adding 'revoked_at' field and changes the behavior of #accessible?. For a grant be accessible it needs to not be either exipired or revoked. The error response when the grant is revoked is 'invalid_grant' as specified here: http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-5.2
| @@ -1,7 +1,7 @@ | |||
| class AccessGrant < ActiveRecord::Base | |||
| include Doorkeeper::OAuth::RandomString | |||
|
|
|||
| self.table_name = "oauth_access_grants" | |||
| self.set_table_name :oauth_access_grants | |||
There was a problem hiding this comment.
Do you need to call self.set... here. Just set_table_name without self is not enough ?
There was a problem hiding this comment.
We don't need self there. Updating...
piotrj
added a commit
that referenced
this pull request
Nov 30, 2011
Authorization code must be short lived and single use
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to specs, access grants must be short lived and single use. This means tha after the access token is issued for a specific grant, the grant must be revoked and cannot be used again.
http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-10.5
This commit upgrades all migration files adding 'revoked_at' field and changes the behavior of #accessible?. For a grant be accessible it needs to not be either exipired or revoked.
The error response when the grant is revoked is 'invalid_grant' as specified here:
http://tools.ietf.org/html/draft-ietf-oauth-v2-22#section-5.2
I also had to fix an issue when creating the access token, that was issued to the wrong client attribute (uid instead of id)