-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add custom attribute to published output #476
Add custom attribute to published output #476
Conversation
@jacebrowning Would this be something that could be merged after adding missing doc and tests? Can you provide some feedback? |
@chrta Thanks for getting this started! In order see how this feature will work, can you add another |
a563bc9
to
9e259d9
Compare
394a9f2
to
8b1457a
Compare
8b1457a
to
160fccf
Compare
Thanks, I like way that published HTML looks! Are you able to rebase on the upstream
Would you mind opening a separate issue for this? Maybe someone else can help out! |
160fccf
to
976ccbf
Compare
Sorry, this was an issue when i opened this pr in May, this works now. I will remove this from the initial comment. Also rebased to current develop. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This functionality is available in a beta release: https://pypi.org/project/doorstop/2.2b4/ |
Fixes #455
No tests and no documentation added, since this follows the suggestion in #455.
My questions: