Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add custom attribute to published output #476

Merged
merged 2 commits into from
Apr 24, 2021

Conversation

chrta
Copy link
Contributor

@chrta chrta commented May 25, 2020

Fixes #455

No tests and no documentation added, since this follows the suggestion in #455.

My questions:

  1. Is this approach ok, or should this be implemented in a different way?
  2. What kind of tests should be added?
  3. Where should the documentation be added?

@chrta
Copy link
Contributor Author

chrta commented Mar 4, 2021

@jacebrowning Would this be something that could be merged after adding missing doc and tests? Can you provide some feedback?

@jacebrowning jacebrowning temporarily deployed to doorstop-pr-476 March 4, 2021 16:32 Inactive
@jacebrowning
Copy link
Member

@chrta Thanks for getting this started! In order see how this feature will work, can you add another TUT item with some custom attributes configured to be published? Here's what the TUT document looks like currently: https://doorstop-pr-476.herokuapp.com/TUT.html

@chrta chrta force-pushed the add-publish-custom-attribs branch from a563bc9 to 9e259d9 Compare March 5, 2021 09:32
@chrta chrta force-pushed the add-publish-custom-attribs branch 2 times, most recently from 394a9f2 to 8b1457a Compare March 5, 2021 09:49
@jacebrowning
Copy link
Member

Thanks for adding that!

Perhaps the attributes table should only be displayed if there are one or more rows in it?

@chrta chrta force-pushed the add-publish-custom-attribs branch from 8b1457a to 160fccf Compare March 5, 2021 10:48
@jacebrowning
Copy link
Member

Thanks, I like way that published HTML looks! Are you able to rebase on the upstream develop? I think that will fix the deployment failure.

Comment: The tests fail for me (also on my local pc on the develop branch) because of some issue with plantuml.

Would you mind opening a separate issue for this? Maybe someone else can help out!

@chrta chrta force-pushed the add-publish-custom-attribs branch from 160fccf to 976ccbf Compare March 5, 2021 11:47
@chrta
Copy link
Contributor Author

chrta commented Mar 5, 2021

Comment: The tests fail for me (also on my local pc on the develop branch) because of some issue with plantuml.

Would you mind opening a separate issue for this? Maybe someone else can help out!

Sorry, this was an issue when i opened this pr in May, this works now. I will remove this from the initial comment.

Also rebased to current develop.

@chrta chrta changed the title RFC: Add custom attribute to published output Add custom attribute to published output Mar 5, 2021
Copy link
Member

@jacebrowning jacebrowning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@jacebrowning jacebrowning merged commit d32a892 into doorstop-dev:develop Apr 24, 2021
@jacebrowning
Copy link
Member

This functionality is available in a beta release: https://pypi.org/project/doorstop/2.2b4/

@chrta chrta deleted the add-publish-custom-attribs branch May 4, 2021 10:30
@JustinW80 JustinW80 mentioned this pull request Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Export additional properties
2 participants