Promise resolve and reject now return Interrupt errors #624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is so that it can be handled at all. Previously the error was just not propagated which lead to interrupts not really working with asynchronous code. Fixes dop251#623
|
I went with a bare minimum change and test. If you have some other cases which you will want to test I will gladly add them. |
mstoykov
commented
Oct 23, 2024
dop251
reviewed
Oct 23, 2024
dop251
reviewed
Oct 23, 2024
Co-authored-by: Dmitry Panov <dop251@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so that it can be handled at all.
Previously the error was just not propagated which lead to interrupts not really working with asynchronous code.
Fixes #623