Added Windows paths support when requiring local files #61
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a OS dependent absolute path check when requiring local files in order to support Windows absolute paths (eg.
C:\...
).Couple notes:
I'm not sure actually if this should be allowed because the node file modules docs doesn't mention explicitly whether Windows abs path are resolvable or not (or at least I couldn't find).
I've tested with Windows 10 VM and Node 18 and
require("C:\\...")
works there.I'm not sure whether the OS specific separators for
./
and../
should also be added.Edit: for more context, this was reported in pocketbase/pocketbase#3163.