Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tekton compatibility for committime exporter #333

Closed
wants to merge 13 commits into from
Closed

Tekton compatibility for committime exporter #333

wants to merge 13 commits into from

Commits on Mar 2, 2022

  1. First pass of tekton compatibility for committime exporter, 

    copied from dora-metrics#327
    @jlozano-rh @KevinMGranger
    jlozano-rh authored and KevinMGranger committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    5d6dac7 View commit details
    Browse the repository at this point in the history

  2. Refactor committime collector base for readability. 

    Look for tekton data in standard locations.

Add various utility / helper functions.
    @KevinMGranger
    KevinMGranger committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    f41f7a4 View commit details
    Browse the repository at this point in the history

  3. Handle any exceptions that bubble up from tekton 

    While we should make a broader error management strategy,
this is here while tekton support is in preview.
    @KevinMGranger
    KevinMGranger committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    37cc7d5 View commit details
    Browse the repository at this point in the history

  4. Skip git hooks when running demo and push to URL instead

    @KevinMGranger
    KevinMGranger committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    a401063 View commit details
    Browse the repository at this point in the history

  5. Log error message from GitHub response if present 

    Also fix referring to wrong FQDN attribute name
    @KevinMGranger
    KevinMGranger committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    ab424f7 View commit details
    Browse the repository at this point in the history

  6. Grant exporter service account access to tekton resources

    @KevinMGranger
    KevinMGranger committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    3476a1c View commit details
    Browse the repository at this point in the history

  7. Add TypedString utility to reduce mixups with similarly-named string … 

    …variables
    @KevinMGranger
    KevinMGranger committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    b00a207 View commit details
    Browse the repository at this point in the history

  8. Many tekton changes: 

    - use TypedStrings where possible to avoid previous errors
- filter to only use successful pipeline runs
- Rename many variables to be more clear and semantically correct
- Avoid passing around names when already present in objects to reduce errors
    @KevinMGranger
    KevinMGranger committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    2ac28cc View commit details
    Browse the repository at this point in the history

  9. Document which fields of the CommitMetric are actually used

    @KevinMGranger
    KevinMGranger committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    95399a5 View commit details
    Browse the repository at this point in the history

  10. Document methods, remove code collecting some unnecessary commit meta… 

    …data
    @KevinMGranger
    KevinMGranger committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    60d88fc View commit details
    Browse the repository at this point in the history

  11. Move relevant resources to constants in committime base

    @KevinMGranger
    KevinMGranger committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    248b540 View commit details
    Browse the repository at this point in the history

  12. Make apps and pipeline run app labels more resilient

    @KevinMGranger
    KevinMGranger committed Mar 2, 2022
    Configuration menu
    Copy the full SHA
    76f7655 View commit details
    Browse the repository at this point in the history

Commits on Apr 6, 2022

  1. Do committime label gathering in python, not jsonpath

    @KevinMGranger
    KevinMGranger committed Apr 6, 2022
    Configuration menu
    Copy the full SHA
    a721ee3 View commit details
    Browse the repository at this point in the history