Use PULL_NUMBER in e2e tests scripts #487
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CI has one shell env variable PULL_NUMBER which should be used while running e2e tests.
|
/LGTM |
|
worked for me :) Thanks @mpryc |
mpryc
added a commit
to mpryc/pelorus
that referenced
this pull request
Jun 10, 2022
CI has one shell env variable PULL_NUMBER which should be used while running e2e tests. This is same PR as dora-metrics#487, however another merge reverted it, so we need to have this one.
weshayutin
pushed a commit
that referenced
this pull request
Jun 10, 2022
CI has one shell env variable PULL_NUMBER which should be used while running e2e tests. This is same PR as #487, however another merge reverted it, so we need to have this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CI has one shell env variable PULL_NUMBER which should be used while running e2e tests.
This change adds such check and ensures the PULL_NUMBER Is actual number before modyfing values.yaml file.
@redhat-cop/mdt