Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update Tekton demo with optional build types #587

Merged
merged 10 commits into from
Aug 5, 2022
Merged

update Tekton demo with optional build types #587

merged 10 commits into from
Aug 5, 2022

Conversation

weshayutin
Copy link
Contributor

Describe the behavior changes introduced in this PR

Linked Issues?

resolves #526
resolves #478

related to # <-- Use this if it shouldn't

Testing Instructions

check out pull request
./demo-tekton <git_url>

@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 2, 2022
@weshayutin weshayutin changed the title WIP: update Tekton demo with a buildConfig update Tekton demo with optional build types Aug 4, 2022
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 4, 2022
@weshayutin
update makefile for demo-tekton.sh
f87fa2f
@weshayutin
modifying python example, number 1
522e98a
@weshayutin
use v1alpha for Task
11f69d3
@weshayutin
clean up and better debug
45e4480 
* ensure the python-example is NOT running any time prior to the build
  being complete
* add some assurance that the git repo files are there and from the
  right git repo and commit
@weshayutin
Copy link
Contributor Author

@mpryc @KevinMGranger this is ready :)

@mpryc
Copy link
Collaborator

mpryc commented Aug 5, 2022

/test 4.9-e2e-openshift

@mpryc
Copy link
Collaborator

mpryc commented Aug 5, 2022

  1. In the Tekton UI I am getting (while running binary or buildconfig builds):
Pipeline basic-python-tekton/basic-python-tekton-pipeline can't be Run; it contains Tasks that don't exist: Couldn't retrieve Task "debug": tasks.tekton.dev "debug" not found

That's after switching to: apiVersion: tekton.dev/v1alpha1

  1. While running binary build the branch on the repo side is "tekton_buildConfig", thinking laud here if it should be per type of the build, so maybe "tekton_binary" or even to be more explicity "tekton_pelorus_binary", "tekton_pelorus_buildConfig", "tekton_pelorus_s2i".

@weshayutin
Copy link
Contributor Author

@mpryc @KevinMGranger ok... sorry the updated code needs to be in the remote branch. Some changes were required.
to test: ./demo-tekton.sh -r refs/pull/587/head

@mpryc
Copy link
Collaborator

mpryc commented Aug 5, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 5, 2022
@mpryc mpryc merged commit 1ce0b64 into dora-metrics:master Aug 5, 2022
@weshayutin weshayutin mentioned this pull request Aug 8, 2022
Closed
@KevinMGranger KevinMGranger mentioned this pull request Aug 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KevinMGranger KevinMGranger Awaiting requested review from KevinMGranger

@mpryc mpryc Awaiting requested review from mpryc

Assignees

@mpryc mpryc

Labels
lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Milestone
No milestone
2 participants
@weshayutin @mpryc