Add some in-code architecture docs #753
Conversation
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
…mework Signed-off-by: Kevin M Granger <kgranger@redhat.com>
- fixes using items with just `__getitem__` as deserialization sources for classes - adds support for keeping the deserialization source as a field (useful for large objects you still want to work with dynamically) Signed-off-by: Kevin M Granger <kgranger@redhat.com>
There were several typing issues and unclear APIs in the committime exporter. CommitMetric was used as a big blob. It carried all inputs and outputs, with almost no guarantees for when and where things would be set. It also had several unused fields. The way it was meant to be handled by implementors was also unclear: do they modify it on the passed in CommitMetric? do they return a CommitMetric with the committime updated? what if they return None? what if the information needed is missing? There are several spots where a type checker would complain. Including some spots where the variable being used could be unbound! Signed-off-by: Kevin M Granger <kgranger@redhat.com>
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
openshift-ci
bot
added
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
Skipping CI for Draft Pull Request. |
openshift-merge-robot
added
the
needs-rebase
|
@KevinMGranger: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: Kevin M Granger <kgranger@redhat.com>
KevinMGranger
force-pushed
the
architecture_docs
branch
from
526b43b
to
ea0acef
Compare
KevinMGranger
changed the title
|
@KevinMGranger can you update the PR description to link which PR this one depends on? (put |
|
@KevinMGranger: The following tests failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Depends on the committime PR, ignore those changes for now.