Skip to content

Commit

Permalink
Remove cli dataflow path check (#662)
Browse files Browse the repository at this point in the history
Validating dataflow within the CLI is very hard as the CLI does not
record enough information to implement the validation of the dataflow,
creating false error of not valid dataflows.
  • Loading branch information
haixuanTao authored Oct 7, 2024
2 parents 4e428ee + 25666ce commit 6f7b030
Showing 1 changed file with 0 additions and 10 deletions.
10 changes: 0 additions & 10 deletions binaries/cli/src/main.rs
Original file line number Diff line number Diff line change
Expand Up @@ -374,13 +374,6 @@ fn run() -> eyre::Result<()> {
.parent()
.ok_or_else(|| eyre::eyre!("dataflow path has no parent dir"))?
.to_owned();
if !coordinator_addr.is_loopback() {
dataflow_descriptor.check_in_daemon(&working_dir, &[], true)?;
} else {
dataflow_descriptor
.check(&working_dir)
.wrap_err("Could not validate yaml")?;
}

let coordinator_socket = (coordinator_addr, coordinator_port).into();
let mut session = connect_to_coordinator(coordinator_socket)
Expand Down Expand Up @@ -498,9 +491,6 @@ fn run() -> eyre::Result<()> {
handle_dataflow_result(result, None)
}
None => {
if coordinator_addr == LOCALHOST {
tracing::info!("Starting in local mode");
}
Daemon::run(SocketAddr::new(coordinator_addr, coordinator_port), machine_id.unwrap_or_default(), inter_daemon_addr, local_listen_port).await
}
}
Expand Down

0 comments on commit 6f7b030

Please sign in to comment.