Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create dataflow html file in current directory #115

Merged
merged 1 commit into from
Oct 28, 2022
Merged

Create dataflow html file in current directory #115

merged 1 commit into from
Oct 28, 2022

Conversation

phil-opp
Copy link
Collaborator

Chrome does not permit opening HTML files from the tmp directory.

@phil-opp
Create dataflow html file in current directory
37bc57f 
Chrome does not permit opening HTML files from the tmp directory.
@phil-opp phil-opp requested a review from heyong4725 October 26, 2022 13:06
@phil-opp
Copy link
Collaborator Author

@heyong4725 Could you check whether it work for you now? You can also pass an --open flag to open the file directly in the default browser.

@phil-opp phil-opp mentioned this pull request Oct 26, 2022
Open
28 tasks
@heyong4725
Copy link
Collaborator

I verified this fix works!

@heyong4725 heyong4725 closed this Oct 26, 2022
@heyong4725 heyong4725 reopened this Oct 26, 2022
@heyong4725
Copy link
Collaborator

It works! @phil-opp

@phil-opp
Copy link
Collaborator Author

Great, thanks for testing!

@phil-opp phil-opp merged commit eff266c into main Oct 28, 2022
@phil-opp phil-opp deleted the fix-graph branch October 28, 2022 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heyong4725 heyong4725 heyong4725 approved these changes

@haixuanTao haixuanTao haixuanTao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@phil-opp @heyong4725 @haixuanTao