-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove borrow on node.send_output
for python
#753
Draft
haixuanTao
wants to merge
5
commits into
main
Choose a base branch
from
remove-borrow-on-send-output
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
4c59df0
Adding outtetts as TTS
haixuanTao 6b39782
Adding examples
haixuanTao 64bc6aa
Add mlx version for whisper on macos
haixuanTao 2c3da71
Downgrade dev dependency for better support for old python version
haixuanTao 84c6244
Remove borrow on send_output to avoid double mutable borrow on node
haixuanTao File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
*.pt | ||
*.json | ||
*.npz |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,10 @@ | ||
# Dora Speech to Text example | ||
|
||
Make sure to have, dora, pip and cargo installed. | ||
|
||
```bash | ||
dora build https://raw.githubusercontent.com/dora-rs/dora/main/examples/speech-to-speech/outtetts.yml | ||
dora run https://raw.githubusercontent.com/dora-rs/dora/main/examples/speech-to-speech/outtetts.yml | ||
|
||
# Wait for models to download which can takes a bit of time. | ||
``` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,40 @@ | ||
nodes: | ||
- id: dora-microphone | ||
build: pip install -e ../../node-hub/dora-microphone | ||
path: dora-microphone | ||
inputs: | ||
tick: dora/timer/millis/2000 | ||
outputs: | ||
- audio | ||
|
||
- id: dora-vad | ||
build: pip install -e ../../node-hub/dora-vad | ||
path: dora-vad | ||
inputs: | ||
audio: dora-microphone/audio | ||
outputs: | ||
- audio | ||
|
||
- id: dora-distil-whisper | ||
build: pip install -e ../../node-hub/dora-distil-whisper | ||
path: dora-distil-whisper | ||
inputs: | ||
input: dora-vad/audio | ||
outputs: | ||
- text | ||
env: | ||
TARGET_LANGUAGE: english | ||
# For China | ||
# USE_MODELSCOPE_HUB: true | ||
|
||
- id: dora-outtetts | ||
build: pip install -e ../../node-hub/dora-outtetts | ||
path: dora-outtetts | ||
inputs: | ||
text: dora-whisper/text | ||
|
||
- id: dora-rerun | ||
build: cargo build -p dora-rerun --release | ||
path: dora-rerun | ||
inputs: | ||
original_text: dora-distil-whisper/text |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
nodes: | ||
- id: dora-microphone | ||
description: Microphone | ||
build: pip install dora-microphone | ||
path: dora-microphone | ||
inputs: | ||
tick: dora/timer/millis/2000 | ||
outputs: | ||
- audio | ||
|
||
- id: dora-vad | ||
build: pip install dora-vad | ||
path: dora-vad | ||
inputs: | ||
audio: dora-microphone/audio | ||
outputs: | ||
- audio | ||
|
||
- id: dora-whisper | ||
build: pip install dora-distil-whisper | ||
path: dora-distil-whisper | ||
inputs: | ||
input: dora-vad/audio | ||
outputs: | ||
- text | ||
env: | ||
TARGET_LANGUAGE: english | ||
|
||
- id: dora-outtetts | ||
build: pip install dora-outtetts | ||
path: dora-outtetts | ||
inputs: | ||
text: dora-whisper/text | ||
|
||
- id: dora-rerun | ||
build: pip install dora-rerun | ||
path: dora-rerun | ||
inputs: | ||
original_text: dora-whisper/text |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,37 @@ | ||
# dora-outtetts | ||
|
||
## Getting started | ||
|
||
- Install it with pip: | ||
|
||
```bash | ||
pip install -e . | ||
``` | ||
|
||
## Contribution Guide | ||
|
||
- Format with [black](https://github.com/psf/black): | ||
|
||
```bash | ||
black . # Format | ||
``` | ||
|
||
- Lint with [pylint](https://github.com/pylint-dev/pylint): | ||
|
||
```bash | ||
pylint --disable=C,R --ignored-modules=cv2 . # Lint | ||
``` | ||
|
||
- Test with [pytest](https://github.com/pytest-dev/pytest) | ||
|
||
```bash | ||
pytest . # Test | ||
``` | ||
|
||
## YAML Specification | ||
|
||
## Examples | ||
|
||
## License | ||
|
||
dora-outtetts's code are released under the MIT License |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
import os | ||
|
||
# Define the path to the README file relative to the package directory | ||
readme_path = os.path.join(os.path.dirname(os.path.dirname(__file__)), "README.md") | ||
|
||
# Read the content of the README file | ||
try: | ||
with open(readme_path, "r", encoding="utf-8") as f: | ||
__doc__ = f.read() | ||
except FileNotFoundError: | ||
__doc__ = "README file not found." |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
from .main import main | ||
|
||
|
||
if __name__ == "__main__": | ||
main() |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will still error when used concurrently. So the error just happens in a different place now, but concurrent operations are still not possible.