Skip to content
This repository was archived by the owner on Jan 23, 2024. It is now read-only.

Commit 33f8f33

Browse files
authored
Merge pull request #452 from dora-team/rename-gcb-pubsub-topic
rename cloud build pubsub topic
2 parents d1bfdd6 + fa65862 commit 33f8f33

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

terraform/modules/fourkeys-cloud-build-parser/README.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,8 @@
1+
This module creates the pubsub topic and parser for Cloud Build. The name of the pubsub topic is important!
2+
3+
Cloud Build is designed so that if a topic exists named `cloud-builds`, build events are automatically written to it. But that topic is not created by default, [it has to be deliberately created](https://cloud.google.com/build/docs/subscribe-build-notifications#receiving_build_notifications).
4+
5+
16
<!-- BEGIN_TF_DOCS -->
27
## Requirements
38

terraform/modules/fourkeys-cloud-build-parser/main.tf

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ resource "google_cloud_run_service" "cloudbuild_parser" {
4646

4747
resource "google_pubsub_topic" "cloudbuild" {
4848
project = var.project_id
49-
name = "cloudbuild"
49+
name = "cloud-builds"
5050
}
5151

5252
resource "google_pubsub_topic_iam_member" "service_account_editor" {

0 commit comments

Comments
 (0)