feat: add config parameter for predicate quantifier #224
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting the new 'predicate-quantifier' configuration parameter to 'every' makes it so that all the patterns have to match a file for it to be considered changed. This can be leveraged to ensure that you only build & test software changes that have real impact on the behavior of the code, e.g. you can set up your build to run when Typescript/Rust/etc. files are changed but markdown changes in the diff will be ignored and you consume less resources to build. The default behavior does not change by the introduction of this feature so upgrading can be done safely knowing that existing workflows will not break. Signed-off-by: Peter Somogyvari <peter.somogyvari@accenture.com>
petermetz
commented
Feb 22, 2024
5 tasks
|
ok |
|
@PetersonBenhameCEO Thank you! |
|
@petermetz Thanks for the PR. It's very well-prepared. I will merge it now and release a new version. |
@dorny Yay, thank you very much! Looking forward to using the new release in our CI! 🎉 |
|
Released as v3.0.2 |
jayaddison
added a commit
to openculinary/openfoodfacts-server
that referenced
this pull request
Mar 27, 2025
In openfoodfacts#11624 the original plan was to add some negative matching blobs using `paths-filter`, but that did not function as intended. As a result of that, we switched to use `tj-actions/paths-filter` instead, in pull requests openfoodfacts#11630 and openfoodfacts#11644. The reason `changed-files` did not work as expected is/was the lack of dorny/paths-filter#224 - a feature only available from v3.0.2 onwards. This changeset enables support for the `predicate-quantifier` setting and configures it for the negative-blob matches on the `code` fileset.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the new 'predicate-quantifier' configuration parameter to 'every'
makes it so that all the patterns have to match a file for it to be
considered changed.
This can be leveraged to ensure that you only build & test software changes
that have real impact on the behavior of the code, e.g. you can set up your
build to run when Typescript/Rust/etc. files are changed but markdown
changes in the diff will be ignored and you consume less resources to build.
The default behavior does not change by the introduction of this feature
so upgrading can be done safely knowing that existing workflows will not
break.
Signed-off-by: Peter Somogyvari peter.somogyvari@accenture.com