Skip to content
This repository has been archived by the owner on Jan 5, 2025. It is now read-only.

fix: use Fhir Http client to hard delete patients #11

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

liammoat
Copy link
Contributor

PdsServiceTests has a method which deletes Patient resources from the Fhir Service. By default, this operation is a soft delete.

The remaining "soft" copy of the resource prevents subsequent tests from running successfully - due to the 410 GONE Http result.

This PR updates the CleanFhirStore to "hard" delete the resource, using the hardDelete query parameters:

Patient/9000000025?hardDelete=true

Subsequent requests for "9000000025" will now result in a 404:

image

NOTE: This only affects the Integration.Tests project.

@liammoat liammoat requested a review from gaurarpit April 16, 2024 20:19
@liammoat liammoat self-assigned this Apr 16, 2024
@liammoat liammoat requested review from johncollinson2001 and gaurarpit and removed request for gaurarpit and johncollinson2001 April 16, 2024 20:19
@liammoat
Copy link
Contributor Author

@johncollinson2001, might be worth capturing a PBI to update the CleanFhirStore method to use the $bulk-delete operation. This PR is to get subsequent tests working, but the operation is still slow running.

Copy link
Contributor

@gaurarpit gaurarpit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thank you for the change. 1 small comment.

@gaurarpit gaurarpit merged commit 3cfc3fe into main Apr 17, 2024
2 checks passed
@gaurarpit gaurarpit deleted the fix/hard-delete-in-tests branch April 17, 2024 08:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants