Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix reply ordering per endpoint #224

Merged
merged 1 commit into from
Jan 28, 2022
Merged

Fix reply ordering per endpoint #224

merged 1 commit into from
Jan 28, 2022

Conversation

dorssel
Copy link
Owner

@dorssel dorssel commented Jan 23, 2022

Fixes #219

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #224 (ac039de) into master (df8c099) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #224      +/-   ##
==========================================
- Coverage   34.13%   34.06%   -0.08%     
==========================================
  Files          23       23              
  Lines        1910     1914       +4     
==========================================
  Hits          652      652              
- Misses       1258     1262       +4     
Impacted Files Coverage Δ
UsbIpServer/AttachedClient.cs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df8c099...ac039de. Read the comment docs.

Copy link

@eteq eteq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it does indeed resolve #219 !

(I also gave the PR a line-by-line read, and while my C# is not that strong, I didn't have any changes to suggest!)

@dorssel dorssel merged commit 9218cbd into master Jan 28, 2022
@dorssel dorssel deleted the ordered_replies branch January 28, 2022 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

usbipd sometimes scrambles USB serial devices charater order
2 participants