Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map USBSUP_XFER_DNR to EPIPE instead of ETIME #812

Closed
wants to merge 1 commit into from
Closed

Conversation

dorssel
Copy link
Owner

@dorssel dorssel commented Dec 23, 2023

See #807

@@ -112,7 +112,9 @@
{
UsbSupError.USBSUP_XFER_OK => Errno.SUCCESS,
UsbSupError.USBSUP_XFER_STALL => Errno.EPIPE,
UsbSupError.USBSUP_XFER_DNR => Errno.ETIME,
// HACK: see https://github.com/dorssel/usbipd-win/issues/807

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
@@ -190,7 +190,9 @@
{
{ UsbSupError.USBSUP_XFER_OK, Errno.SUCCESS },
{ UsbSupError.USBSUP_XFER_STALL, Errno.EPIPE },
{ UsbSupError.USBSUP_XFER_DNR, Errno.ETIME },
// HACK: see https://github.com/dorssel/usbipd-win/issues/807

Check notice

Code scanning / devskim

A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note

Suspicious comment
Copy link
Contributor

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 8 0 0.05s
✅ BASH bash-exec 1 0 0.01s
✅ BASH shellcheck 1 0 0.09s
✅ BASH shfmt 1 0 0.0s
✅ EDITORCONFIG editorconfig-checker 134 0 0.84s
✅ JSON eslint-plugin-jsonc 4 0 1.09s
✅ JSON jsonlint 4 0 0.16s
✅ JSON prettier 4 0 0.49s
✅ JSON v8r 4 0 2.57s
✅ MARKDOWN markdownlint 3 0 0.63s
✅ MARKDOWN markdown-link-check 3 0 6.67s
✅ MARKDOWN markdown-table-formatter 3 0 0.46s
✅ REPOSITORY checkov yes no 11.86s
✅ REPOSITORY gitleaks yes no 2.86s
✅ REPOSITORY git_diff yes no 0.07s
✅ REPOSITORY grype yes no 12.67s
✅ REPOSITORY secretlint yes no 0.99s
✅ REPOSITORY trivy yes no 7.45s
✅ REPOSITORY trivy-sbom yes no 2.24s
✅ REPOSITORY trufflehog yes no 5.19s
✅ XML xmllint 14 0 0.02s
✅ YAML prettier 13 0 1.29s
✅ YAML v8r 13 0 10.25s
✅ YAML yamllint 13 0 0.36s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

Test Results

2 730 tests  ±0   2 730 ✅ ±0   7s ⏱️ ±0s
    1 suites ±0       0 💤 ±0 
    1 files   ±0       0 ❌ ±0 

Results for commit 972d742. ± Comparison against base commit 2d82098.

This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
UnitTests.Tools_Tests ‑ ConvertError_Test (USBSUP_XFER_DNR,ETIME)
UnitTests.Tools_Tests ‑ ConvertError_Test (USBSUP_XFER_DNR,EPIPE)

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d82098) 42.12% compared to head (972d742) 42.16%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #812      +/-   ##
==========================================
+ Coverage   42.12%   42.16%   +0.04%     
==========================================
  Files          32       32              
  Lines        2730     2732       +2     
  Branches      390      390              
==========================================
+ Hits         1150     1152       +2     
  Misses       1544     1544              
  Partials       36       36              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorssel dorssel closed this Dec 29, 2023
@dorssel dorssel deleted the test_807 branch December 29, 2023 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant