-
-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Map USBSUP_XFER_DNR to EPIPE instead of ETIME #812
Conversation
@@ -112,7 +112,9 @@ | |||
{ | |||
UsbSupError.USBSUP_XFER_OK => Errno.SUCCESS, | |||
UsbSupError.USBSUP_XFER_STALL => Errno.EPIPE, | |||
UsbSupError.USBSUP_XFER_DNR => Errno.ETIME, | |||
// HACK: see https://github.com/dorssel/usbipd-win/issues/807 |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
@@ -190,7 +190,9 @@ | |||
{ | |||
{ UsbSupError.USBSUP_XFER_OK, Errno.SUCCESS }, | |||
{ UsbSupError.USBSUP_XFER_STALL, Errno.EPIPE }, | |||
{ UsbSupError.USBSUP_XFER_DNR, Errno.ETIME }, | |||
// HACK: see https://github.com/dorssel/usbipd-win/issues/807 |
Check notice
Code scanning / devskim
A "TODO" or similar was left in source code, possibly indicating incomplete functionality Note
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports |
Test Results2 730 tests ±0 2 730 ✅ ±0 7s ⏱️ ±0s Results for commit 972d742. ± Comparison against base commit 2d82098. This pull request removes 1 and adds 1 tests. Note that renamed tests count towards both.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #812 +/- ##
==========================================
+ Coverage 42.12% 42.16% +0.04%
==========================================
Files 32 32
Lines 2730 2732 +2
Branches 390 390
==========================================
+ Hits 1150 1152 +2
Misses 1544 1544
Partials 36 36 ☔ View full report in Codecov by Sentry. |
See #807