Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add policy rules #916

Merged
merged 4 commits into from
Apr 17, 2024
Merged

Add policy rules #916

merged 4 commits into from
Apr 17, 2024

Conversation

dorssel
Copy link
Owner

@dorssel dorssel commented Apr 7, 2024

No description provided.

Usbipd/Program.cs Fixed Show fixed Hide fixed
Usbipd/Program.cs Fixed Show fixed Hide fixed
Copy link
Contributor

github-actions bot commented Apr 7, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ ACTION actionlint 8 0 0.02s
✅ BASH bash-exec 1 0 0.0s
✅ BASH shellcheck 1 0 0.05s
✅ BASH shfmt 1 0 0.26s
✅ EDITORCONFIG editorconfig-checker 158 0 0.63s
✅ JSON eslint-plugin-jsonc 4 0 1.23s
✅ JSON jsonlint 4 0 0.2s
✅ JSON prettier 4 0 0.44s
✅ JSON v8r 4 0 2.68s
✅ MARKDOWN markdownlint 3 0 0.53s
✅ MARKDOWN markdown-link-check 3 0 7.21s
✅ MARKDOWN markdown-table-formatter 3 0 0.3s
✅ REPOSITORY checkov yes no 11.94s
✅ REPOSITORY gitleaks yes no 2.48s
✅ REPOSITORY git_diff yes no 0.09s
✅ REPOSITORY grype yes no 11.3s
✅ REPOSITORY secretlint yes no 1.13s
✅ REPOSITORY trivy yes no 7.42s
✅ REPOSITORY trivy-sbom yes no 6.62s
✅ REPOSITORY trufflehog yes no 7.36s
✅ XML xmllint 15 0 0.01s
✅ YAML prettier 13 0 1.26s
✅ YAML v8r 13 0 8.63s
✅ YAML yamllint 13 0 0.42s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link
Contributor

github-actions bot commented Apr 7, 2024

Test Results

2 937 tests  +32   2 937 ✅ +32   6s ⏱️ ±0s
    1 suites ± 0       0 💤 ± 0 
    1 files   ± 0       0 ❌ ± 0 

Results for commit 42415ad. ± Comparison against base commit 46c7f5c.

This pull request removes 1361 and adds 1393 tests. Note that renamed tests count towards both.
UnitTests.BusId_Tests ‑ Compare (1-1,1-65534,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,1-65535,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,2-65534,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,2-65535,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,65534-1,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,65534-2,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,65534-65534,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,65534-65535,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,65535-1,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,65535-2,-1)
…
UnitTests.BusId_Tests ‑ Compare (1-1,1-98,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,1-99,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,2-98,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,2-99,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,98-1,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,98-2,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,98-98,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,98-99,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,99-1,-1)
UnitTests.BusId_Tests ‑ Compare (1-1,99-2,-1)
…

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Apr 7, 2024

Codecov Report

Attention: Patch coverage is 57.35849% with 113 lines in your changes are missing coverage. Please review.

Project coverage is 42.91%. Comparing base (46c7f5c) to head (42415ad).

Files Patch % Lines
Usbipd/RegistryUtils.cs 6.66% 42 Missing ⚠️
Usbipd/CommandHandlersCli.cs 0.00% 37 Missing ⚠️
Usbipd/ConnectedClient.cs 0.00% 27 Missing ⚠️
Usbipd/Policy.cs 0.00% 4 Missing ⚠️
Usbipd/Program.cs 98.38% 1 Missing and 1 partial ⚠️
Usbipd/PolicyRuleAutoBind.cs 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #916      +/-   ##
==========================================
+ Coverage   41.60%   42.91%   +1.31%     
==========================================
  Files          34       38       +4     
  Lines        2810     3064     +254     
  Branches      404      446      +42     
==========================================
+ Hits         1169     1315     +146     
- Misses       1610     1716     +106     
- Partials       31       33       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dorssel dorssel force-pushed the rules branch 2 times, most recently from 7c3ef3c to 124900b Compare April 14, 2024 07:04
@dorssel dorssel changed the title Add rules Add policy rules Apr 14, 2024
@dorssel dorssel force-pushed the rules branch 2 times, most recently from 69a8b68 to 9038dff Compare April 17, 2024 14:33
@dorssel dorssel marked this pull request as ready for review April 17, 2024 15:51
@dorssel dorssel merged commit fc51ba5 into master Apr 17, 2024
10 checks passed
@dorssel dorssel deleted the rules branch April 17, 2024 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant