Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are creating a new model in the CubeJS Schema so called events but what it really mean? and why we need a new model?
First right now we have a couple of model:
but how we set the model in the CubeJS Query:
This is a query to count how many request we have:
but if we want to count how many events we have:
I know that include the model make the query more difficult so maybe we can figure out witch model the user want to use without force him to include it, for example if the user include fields like event_type or event_source then he want to use the event model but if it include field like bounceRateSuccesses success then he want to use the session model and we can use request all the time as default, I still don't know if this is a good idea but I would like to know your opinion about it.