-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump compileSdk, update dependencies, fix #18, #19 and #20 #33
base: master
Are you sure you want to change the base?
Conversation
…rate to "androidx" from "android.support"
…ids, ThemeTest is now ignored on too old Android versions, NewPinTest has better error messages for failed toast test
…save it, fixes issue dotWee#18
… a "public" notification version for private notifications
If this isn't done then pressing on a notification might unexpectedly resume the previous activity
Holy shit, thank you for your contribution! It's been some time working for me with the Android SDK and i already considered this project as discontinued with no plans on keeping it updated, nor releasing another version. Yet it looks like you put in serious work on fixing the open issues and updating the source to the current API standards. I'm currently on a tight schedule with finals week coming closer, so it will probably take me a few weeks for a full review. After taking a deeper look at your changes, i'll merge it and release (maybe one last) version. One question tho: Since this project doesn't serve me any use except nostalgia, would you interested in taking over this project, maybe even taking the ownership of the Google Play Store application / F-Droid project? |
Glad you liked the changes! I signed my own version of the app for private use so you don't have to hurry up a release for my sake. Still, it could be convenient to have an updated version for when I am using other devices and of course other people might appreciate these changes. I don't have a Google Play developer account so I don't think transferring ownership is possible. Also I haven't really done much development on Android apps so don't know how appropriate I would be to manage it, even if I could probably figure it out. |
I started experimenting with some extra features on a new branch |
Previously I was using another app (Notification Memo) but it got a lot buggier in Android 13 so I searched for alternatives and found this app on F-Droid as well as another app called p!n. Of the apps I found I prefer most things in this app but it had some bugs and therefore I made some changes in order to fix those.
androidx
fromandroid.support
.Edit:
I did some additional changes as I found more things to fix:
android:noHistory
totrue
in order for the app to close when you back out of it. If this isn't done then tapping a notification to edit it after one previously backed out of creating a new pin causes weird behavior. Specifically the app is reopened with the unfinished new pin.MainDialog.java
. This is because it failed the first check in the reboot receiver at line 21 ofOnBootReceiver.java
. I removed that check and added a different check so that the restore code only runs once after the app is started. Force stopping the app or restarting the phone should still cause the notifications to be restored. This fixes When upgrading app current pin notifications disappear until reboot. #23.