fix: make codegen scalars 'any' type #344
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Custom scalars in a schema are hard coded to 'string' type in the TypeScript and Flow codegen types. This leads to many type errors when scalars aren't actually represented as strings. This PR changes the hard coded default to just an 'any' type for now. It might be better in the future to allow users to define custom scalars like in graphql-codegen or
--passthroughCustomScalars
in apollo-codegen but for now this will at least allow the code to compile without having to use@ts-ignore