Fix TypeScript codegen for list input field types #345
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the TypeScript generated code for list input field types does not correctly generate accurate types. If the list is nullable and the item is nullable it does not create an array item for the list type. It also creates a union with the array type and the type in the array which is not accurate since GraphQL will not accept that. This can be fixed by using the same logic that the
renderFieldType
method uses (which works correctly) for lists forrenderInputFieldType
Given the following schema input:
the following TypeScript code is generated:
After this PR the following code will be generated instead: