fix(hasura-allow-list): nested fragment definitions order in document order #822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 0d1e2ed The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Fixes issue when using hasura-allow-list with fragmentsOrder set to 'document' and the fragments are spread across different files. The order of the fragments end up in reverse order.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes issue when using hasura-allow-list with fragmentsOrder set to 'document' and the fragments are spread across different files. The order of the fragments end up in reverse order. Sort by the key in the
FragmentSpreadvisitor to get the same order of fragments in the query allow list as generated by other plugins whenfragmentsOrderis set todocument.Related #821
Type of change
How Has This Been Tested?
I tested the change using the reproduction example in the following repo: https://github.com/voldern/hasura-allowlist-reproduction. In addition to that I've tested it and used it in our own repository for a week now without issues.
See issue for steps to reproduce issue.
Checklist:
CONTRIBUTING doc and the
style guidelines of this project