Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add empty object in place of variables for more consistent keys #894

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rliljest
Copy link

Description

Addresses potential issues stemming from mismatched generated keys.

Related #866

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

NOTE: Does have a fairly minor breaking change in case clients were hard-coding keys (not using generated helpers) and specifying "exact" react-query key matching

How Has This Been Tested?

Automated tests have been updated to accommodate this change

Test Environment:

  • OS: macOS
  • @graphql-codegen/typescript-react-query: 6.1.0

Checklist:

  • I have followed the
    CONTRIBUTING doc and the
    style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Copy link

changeset-bot bot commented Nov 12, 2024

🦋 Changeset detected

Latest commit: 3794bb1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphql-codegen/typescript-react-query Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant