Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PR #8497 typescript-react-query infiniteQuery pageParamKey update introduced breaking change for some users #8566

Closed
EandrewJones opened this issue Nov 2, 2022 · 1 comment
Closed

PR #8497 typescript-react-query infiniteQuery pageParamKey update introduced breaking change for some users #8566

EandrewJones opened this issue Nov 2, 2022 · 1 comment
Labels
stage/6-released The issue has been solved on a released version of the library

Comments

@EandrewJones
Copy link
Contributor

EandrewJones commented Nov 2, 2022 •
edited
Loading

Please see @marcmll's comment below:
#8497 (comment)

I will open a new PR to only overwrite the variables with pageParamKey when its value is defined:

(metaData) => fetcher<${operationResultType}, ${operationVariablesTypes}>(client, ${documentVariableName}, {...variables, ...(metaData.pageParam ? { [pageParamKey]: metaData.pageParam } : {}}, headers)(),
EandrewJones added a commit to EandrewJones/graphql-code-generator that referenced this issue Nov 2, 2022
@EandrewJones
fix breaking change in dotansimha#8566; optionally pass metaData.page…
cc7f529 
…Param to pageParamKey only when it is defined
@EandrewJones EandrewJones mentioned this issue Nov 2, 2022
Merged
10 tasks
saihaj pushed a commit that referenced this issue Nov 4, 2022
@EandrewJones @charlypoly
Hotfix for typescript react query infinite query breaking change (#8567)
af40efb 
* fixes issue #7549

* update dev-test types #7549

* Create sweet-nails-tie.md

* fix breaking change in #8566; optionally pass metaData.pageParam to pageParamKey only when it is defined

Co-authored-by: Charly POLY <1252066+charlypoly@users.noreply.github.com>
@saihaj saihaj added the stage/6-released The issue has been solved on a released version of the library label Nov 4, 2022
@saihaj
Copy link
Collaborator

saihaj commented Nov 4, 2022

released https://github.com/dotansimha/graphql-code-generator/releases/tag/release-1667578711788

@saihaj saihaj closed this as completed Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stage/6-released The issue has been solved on a released version of the library
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@EandrewJones @saihaj