[resolvers] Add avoidCheckingAbstractTypesRecursively option to support nested defaultMappers
#10141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sively checks and generates abstract nested types
🦋 Changeset detectedLatest commit: ddc58bc The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/visitor-plugin-common |
5.5.0-alpha-20241014102200-ddc58bcd59abae2c907ea72c013c42ae94232b54 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-document-nodes |
4.0.11-alpha-20241014102200-ddc58bcd59abae2c907ea72c013c42ae94232b54 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/gql-tag-operations |
4.0.11-alpha-20241014102200-ddc58bcd59abae2c907ea72c013c42ae94232b54 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
4.3.1-alpha-20241014102200-ddc58bcd59abae2c907ea72c013c42ae94232b54 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
4.4.0-alpha-20241014102200-ddc58bcd59abae2c907ea72c013c42ae94232b54 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typed-document-node |
5.0.11-alpha-20241014102200-ddc58bcd59abae2c907ea72c013c42ae94232b54 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript |
4.1.1-alpha-20241014102200-ddc58bcd59abae2c907ea72c013c42ae94232b54 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
4.5.0-alpha-20241014102200-ddc58bcd59abae2c907ea72c013c42ae94232b54 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/graphql-modules-preset |
4.0.11-alpha-20241014102200-ddc58bcd59abae2c907ea72c013c42ae94232b54 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/plugin-helpers |
5.1.0-alpha-20241014102200-ddc58bcd59abae2c907ea72c013c42ae94232b54 |
npm ↗︎ unpkg ↗︎ |
💻 Website PreviewThe latest changes are available as preview in: https://48f1ecf8.graphql-code-generator.pages.dev |
|
Hi, any chance to merge it soon? This is a much-needed feature! |
dotansimha
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Related #10084
In #10014, we fixed an issue where nested abstract types were not getting the correct types. This, however, caused existing usage of nested
defaultMapperto be in an infinite loop.This PR adds
avoidCheckingAbstractTypesRecursivelyoption to preserve the existingdefaultMapperbehaviours by setting totrueType of change
How Has This Been Tested?