Add |undefined in the TypedDocumentString constructor to make it work with --isolatedDeclarations #10160
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with --isolatedDeclarations Without this, tsc gives the error: "Declaration emit for this parameter requires implicitly adding undefined to it's type. This is not supported with --isolatedDeclarations."
🦋 Changeset detectedLatest commit: 69562a4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jyasskin
added a commit
to w3ctag/w3ctagbot
that referenced
this pull request
Oct 3, 2024
This also fixes most of the issues for passing --isolatedDeclarations except for dotansimha/graphql-code-generator#10160 and microsoft/TypeScript#58262.
enisdenjo
requested changes
Oct 8, 2024
Co-authored-by: Denis Badurina <badurinadenis@gmail.com>
|
I made that change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 IMPORTANT: Please do not create a Pull Request without creating an issue first.
Any change needs to be discussed before proceeding. Failure to do so may result in the rejection of the pull request.
(Sorry, this seemed simple enough that the discussion may as well happen here. Feel free to reject it if this is the wrong fix or you don't want to support --isolatedDeclarations.)
Description
Without this, building the generated types into a project that uses --isolatedDeclarations fails with
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
I haven't rebuilt my code with the updated library to make sure that this change makes the change I expect to the generated code.
Test Environment:
Checklist: