[operations] CODEGEN-784 - Fix Apollo @unmask fragmentRefs #10302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 5ef68e7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
💻 Website PreviewThe latest changes are available as preview in: https://76ad1af2.graphql-code-generator.pages.dev |
Contributor
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/visitor-plugin-common |
5.7.1-alpha-20250221122145-5ef68e775c396313780244f87714d33191a46522 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-document-nodes |
4.0.15-alpha-20250221122145-5ef68e775c396313780244f87714d33191a46522 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/gql-tag-operations |
4.0.16-alpha-20250221122145-5ef68e775c396313780244f87714d33191a46522 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
4.5.1-alpha-20250221122145-5ef68e775c396313780244f87714d33191a46522 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
4.4.4-alpha-20250221122145-5ef68e775c396313780244f87714d33191a46522 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typed-document-node |
5.0.15-alpha-20250221122145-5ef68e775c396313780244f87714d33191a46522 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript |
4.1.5-alpha-20250221122145-5ef68e775c396313780244f87714d33191a46522 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
4.6.4-alpha-20250221122145-5ef68e775c396313780244f87714d33191a46522 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/graphql-modules-preset |
4.0.15-alpha-20250221122145-5ef68e775c396313780244f87714d33191a46522 |
npm ↗︎ unpkg ↗︎ |
jerelmiller
reviewed
Feb 21, 2025
| selectionNodes = [...selectionNodes]; | ||
| let inlineFragmentConditional = false; | ||
| for (const selectionNode of selectionNodes) { | ||
| // 1. Handle Field or Directtives selection nodes |
Contributor
There was a problem hiding this comment.
Suggested change
| // 1. Handle Field or Directtives selection nodes | |
| // 1. Handle Field or Directives selection nodes |
Noticed a small typo 🙂
jerelmiller
approved these changes
Feb 21, 2025
Contributor
jerelmiller
left a comment
jerelmiller
left a comment
There was a problem hiding this comment.
I know my approval doesn't mean much here, but this looks right to me. Thanks so much for helping out! Much simpler than I realized this would be 🙌
dotansimha
approved these changes
Feb 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When using Apollo masking features, an
@unmaskfragment is the same as inlined i.e.$fragmentRefsReference: #10299
Type of change
Please delete options that are not relevant.
How Has This Been Tested?