Add gqlImportFrom option #1344
Merged
Add gqlImportFrom option #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielkcz
force-pushed
the
gql-import
branch
4 times, most recently
from
a148019 to
35f8e4f
Compare
danielkcz
force-pushed
the
gql-import
branch
from
35f8e4f to
c2ebcb9
Compare
|
I think this could also fix #1321, right? Although, it feels a little brittle to specify the whole import line. |
I kinda agree. It was just first shot. I am open to suggestions, but let's not build an AI for one code line :) |
|
Looks good. @FredyC please rebase and then I'll merge it :) |
|
Wow, did not know it's possible to resolve conflicts within the GitHub, very neat :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #1342
Once again I am not sure if there is a better way to handle the default config.
Edit: On the contrary to a drafted solution, I had to opt for configuring whole import line because
graphql.macrodoes not have a default export.