Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to ignore tests to build example script, ignore failed example-react-nextjs-swr test temporarily #9930

Merged
merged 3 commits into from
Apr 23, 2024

Conversation

eddeee888
Copy link
Collaborator

@eddeee888 eddeee888 commented Apr 23, 2024

Description

example-react-nextjs-swr has been failing for awhile. In CI, if this test fails, the unit tests are not run which is not ideal. Screenshot attached of skipped unit test:

Screenshot 2024-04-23 at 9 33 20 pm

This PR adds the ability to ignore test examples to print-example-ci-command.js and print matched ignored tests out to terminal.

This should make CI green and we can revisit the failing test soon

Other fixes:

  • Fix failing unit tests because of rimraf@5 no longer allows default export

Type of change

Please delete options that are not relevant.

  • Setup fix (non-breaking change which fixes an issue)

Copy link

changeset-bot bot commented Apr 23, 2024

⚠️ No Changeset found

Latest commit: bd50b59

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link
Contributor

github-actions bot commented Apr 23, 2024

💻 Website Preview

The latest changes are available as preview in: https://b6900013.graphql-code-generator.pages.dev

@enisdenjo enisdenjo merged commit fcdefb6 into master Apr 23, 2024
19 checks passed
@enisdenjo enisdenjo deleted the ignore-failed-test-temporarily branch April 23, 2024 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants