[typescript-resolvers] Add _ prefix to generated RefType as it is sometimes unused
#9944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 1ac284a The changes in this PR will be included in the next version bump. This PR includes changesets to release 9 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🚀 Snapshot Release (
|
| Package | Version | Info |
|---|---|---|
@graphql-codegen/visitor-plugin-common |
5.1.1-alpha-20240425115511-1ac284ac51b27d312ef3f9922218f228a3b468e3 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-document-nodes |
4.0.7-alpha-20240425115511-1ac284ac51b27d312ef3f9922218f228a3b468e3 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/gql-tag-operations |
4.0.7-alpha-20240425115511-1ac284ac51b27d312ef3f9922218f228a3b468e3 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-operations |
4.2.1-alpha-20240425115511-1ac284ac51b27d312ef3f9922218f228a3b468e3 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript-resolvers |
4.0.7-alpha-20240425115511-1ac284ac51b27d312ef3f9922218f228a3b468e3 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typed-document-node |
5.0.7-alpha-20240425115511-1ac284ac51b27d312ef3f9922218f228a3b468e3 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/typescript |
4.0.7-alpha-20240425115511-1ac284ac51b27d312ef3f9922218f228a3b468e3 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/client-preset |
4.2.6-alpha-20240425115511-1ac284ac51b27d312ef3f9922218f228a3b468e3 |
npm ↗︎ unpkg ↗︎ |
@graphql-codegen/graphql-modules-preset |
4.0.7-alpha-20240425115511-1ac284ac51b27d312ef3f9922218f228a3b468e3 |
npm ↗︎ unpkg ↗︎ |
💻 Website PreviewThe latest changes are available as preview in: https://c583db3e.graphql-code-generator.pages.dev |
saihaj
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RefTypeinResolversInterfaceTypesandResolversUnionTypesare unused if the possible types do not refer to other abstract types.This is an issue for codebases using
noUnusedLocals: trueand/ornoUnusedParameters: truecompiler options in their tsconfig.json because it'd throw TypeScript error:This PR prefixes
_toRefTypeto signal that it might not be used. We do this even whenRefTypeis not used so the generated type has a consistent signature for all casesRelated #9584
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...