Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: integration for netlify-edge #1815

Merged
merged 6 commits into from
Sep 29, 2022
Merged

test: integration for netlify-edge #1815

merged 6 commits into from
Sep 29, 2022

Conversation

saihaj
Copy link
Collaborator

@saihaj saihaj commented Sep 28, 2022

made it so we first bundle everything needed for the edge function. This way we can test the local versions and no need to rely on a CDN. Now we can simply just tests the integration.

closes #1515

@changeset-bot
Copy link

changeset-bot bot commented Sep 28, 2022

⚠️ No Changeset found

Latest commit: 6210e1f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@saihaj saihaj self-assigned this Sep 28, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022

🚀 Snapshot Release (alpha)

The latest changes of this PR are available as alpha on npm (based on the declared changesets):

Package Version Info
@graphql-yoga/apollo-link 1.0.0-alpha-20220929101405-049583b1 npm ↗︎ unpkg ↗︎
@graphql-yoga/urql-exchange 1.0.0-alpha-20220929101405-049583b1 npm ↗︎ unpkg ↗︎
@graphql-yoga/common 3.0.0-alpha-20220929101405-049583b1 npm ↗︎ unpkg ↗︎
@graphql-yoga/redis-event-target 1.0.0-alpha-20220929101405-049583b1 npm ↗︎ unpkg ↗︎
@graphql-yoga/typed-event-target 1.0.0-alpha-20220929101405-049583b1 npm ↗︎ unpkg ↗︎
@graphql-yoga/graphiql 3.0.0-alpha-20220929101405-049583b1 npm ↗︎ unpkg ↗︎
graphql-yoga 3.0.0-alpha-20220929101405-049583b1 npm ↗︎ unpkg ↗︎
@graphql-yoga/node 3.0.0-alpha-20220929101405-049583b1 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apollo-inline-trace 1.0.0-alpha-20220929101405-049583b1 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-apq 1.0.0-alpha-20220929101405-049583b1 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-persisted-operations 1.0.0-alpha-20220929101405-049583b1 npm ↗︎ unpkg ↗︎
@graphql-yoga/plugin-response-cache 1.0.0-alpha-20220929101405-049583b1 npm ↗︎ unpkg ↗︎
@graphql-yoga/render-graphiql 3.0.0-alpha-20220929101405-049583b1 npm ↗︎ unpkg ↗︎
@graphql-yoga/subscription 3.0.0-alpha-20220929101405-049583b1 npm ↗︎ unpkg ↗︎

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022

✅ Benchmark Results

     ✓ no_errors
     ✓ expected_result

     checks.........................: 100.00% ✓ 112102      ✗ 0    
     data_received..................: 17 MB   557 kB/s
     data_sent......................: 6.4 MB  215 kB/s
     http_req_blocked...............: avg=1.22µs   min=700ns   med=1.1µs    max=287.1µs p(90)=1.4µs   p(95)=1.7µs   
     http_req_connecting............: avg=2ns      min=0s      med=0s       max=127µs   p(90)=0s      p(95)=0s      
   ✓ http_req_duration..............: avg=458.45µs min=331.7µs med=411.4µs  max=21.41ms p(90)=470.5µs p(95)=550.1µs 
       { expected_response:true }...: avg=458.45µs min=331.7µs med=411.4µs  max=21.41ms p(90)=470.5µs p(95)=550.1µs 
     http_req_failed................: 0.00%   ✓ 0           ✗ 56051
     http_req_receiving.............: avg=18.56µs  min=10.3µs  med=16.2µs   max=3.55ms  p(90)=21.1µs  p(95)=24.8µs  
     http_req_sending...............: avg=5.8µs    min=3.7µs   med=4.89µs   max=4.88ms  p(90)=6.5µs   p(95)=8.5µs   
     http_req_tls_handshaking.......: avg=0s       min=0s      med=0s       max=0s      p(90)=0s      p(95)=0s      
     http_req_waiting...............: avg=434.07µs min=315.1µs med=389.5µs  max=21.29ms p(90)=440.6µs p(95)=515.2µs 
     http_reqs......................: 56051   1868.266787/s
     iteration_duration.............: avg=529.01µs min=383.4µs med=477.39µs max=21.91ms p(90)=545.9µs p(95)=633.25µs
     iterations.....................: 56051   1868.266787/s
     vus............................: 1       min=1         max=1  
     vus_max........................: 1       min=1         max=1  

@github-actions
Copy link
Contributor

github-actions bot commented Sep 28, 2022

🚀 Website Preview

The latest changes to the website are available as preview in: https://741e63fc.graphql-yoga.pages.dev

@ardatan
Copy link
Collaborator

ardatan commented Sep 28, 2022

As far as I know, Edge uses Deno. Maybe we should use pulumi to deploy it via Netlify Edge. @dotansimha any ideas?

@saihaj
Copy link
Collaborator Author

saihaj commented Sep 28, 2022

As far as I know, Edge uses Deno. Maybe we should use pulumi to deploy it via Netlify Edge. @dotansimha any ideas?

yes that is separate issue #1127 and I was exploring netlfiy api to make it happen

Co-authored-by: Denis Badurina <badurinadenis@gmail.com>
@saihaj saihaj requested a review from enisdenjo September 29, 2022 10:13
const { build } = require('esbuild')

async function main() {
await build({
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me but why do we need a build script here?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Netfliy edge does it’s own thing ad wasn’t working when I imported a node module. It liked loading from CI. Instead I made it so we bundle everything and not have to deal with inconsistencies

@saihaj saihaj requested review from ardatan and enisdenjo September 29, 2022 10:42
@saihaj saihaj merged commit 8863ac0 into v3 Sep 29, 2022
@saihaj saihaj deleted the saihaj/netlify branch September 29, 2022 12:58
@saihaj saihaj mentioned this pull request Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants