-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: graphiql enable schema description, default headers #2172
fix: graphiql enable schema description, default headers #2172
Conversation
🦋 Changeset detectedLatest commit: f5cc228 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tuanpt-0634 Do you think you can add an integration test to preventring future regressions?
✅ Benchmark Results
|
GraphiQL schema description
Currently, schema description was intended to enable by default
graphql-yoga/packages/graphiql/src/YogaGraphiQL.tsx
Lines 111 to 119 in 8775f14
But specifying it in
fetcher
props does not work, in this pull I change to useGraphiQLProvider
's props, same as GraphiQL default componentsGraphiQL default headers
We are allowing passing default
headers
when create yoga, but it hasn't been passed toGraphiQLProvider
graphql-yoga/packages/graphql-yoga/src/plugins/useGraphiQL.ts
Lines 21 to 24 in 8775f14
Unused options
https://github.com/graphql/graphiql/blob/main/docs/migration/graphiql-2.0.0.md
defaultVariableEditorOpen
was changed todefaultEditorToolsVisibility
headerEditorEnabled
was changed toisHeadersEditorEnabled
And these two options were enabled by default
graphql-yoga/packages/graphiql/src/YogaGraphiQL.tsx
Lines 157 to 159 in 49b9620