Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop .pnpmfile.cjs and disable NestJS Apollo Federation Compatibility action #2622

Merged
merged 2 commits into from
Mar 29, 2023

Conversation

enisdenjo
Copy link
Collaborator

@enisdenjo enisdenjo commented Mar 29, 2023

Because .pnpmfile.cjs is causing issues with renovate. For example in #2618 (and any other renovate PR at this point in time).

pnpm doesn't support this out-of-the box: pnpm/pnpm#2713. 😑

@changeset-bot
Copy link

changeset-bot bot commented Mar 29, 2023

⚠️ No Changeset found

Latest commit: aa2af8b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

💻 Website Preview

The latest changes are available as preview in: https://f7ad16bb.graphql-yoga.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Mar 29, 2023

❌ Benchmark Failed

Performance regression detected: it seems like your Pull Request adds some extra latency to GraphQL Yoga

If the performance regression is expected, please increase the failing threshold.

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 228650     ✗ 0     
     data_received................................: 943 MB  7.9 MB/s
     data_sent....................................: 46 MB   385 kB/s
     http_req_blocked.............................: avg=2.55µs   min=1.3µs   med=2µs     max=6.28ms  p(90)=2.6µs    p(95)=3µs     
     http_req_connecting..........................: avg=6ns      min=0s      med=0s      max=273.4µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=726.55µs min=334.2µs med=584.8µs max=25.6ms  p(90)=1.02ms   p(95)=1.17ms  
       { expected_response:true }.................: avg=726.55µs min=334.2µs med=584.8µs max=25.6ms  p(90)=1.02ms   p(95)=1.17ms  
     ✓ { mode:graphql-jit }.......................: avg=585.41µs min=334.2µs med=501.4µs max=21.28ms p(90)=675.4µs  p(95)=790.32µs
     ✗ { mode:graphql-no-parse-validate-cache }...: avg=1.09ms   min=733µs   med=977µs   max=21.99ms p(90)=1.23ms   p(95)=1.59ms  
     ✓ { mode:graphql-response-cache }............: avg=611.16µs min=373µs   med=524.5µs max=13.06ms p(90)=709.12µs p(95)=819.7µs 
     ✓ { mode:graphql }...........................: avg=749.88µs min=447.4µs med=634.6µs max=25.6ms  p(90)=862.45µs p(95)=1.05ms  
     http_req_failed..............................: 0.00%   ✓ 0          ✗ 114325
     http_req_receiving...........................: avg=42.82µs  min=20.5µs  med=35µs    max=12.12ms p(90)=54.6µs   p(95)=68.59µs 
     http_req_sending.............................: avg=19.86µs  min=7.7µs   med=11.3µs  max=6.47ms  p(90)=21.7µs   p(95)=29.9µs  
     http_req_tls_handshaking.....................: avg=0s       min=0s      med=0s      max=0s      p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=663.86µs min=301.2µs med=529.3µs max=25.15ms p(90)=955.7µs  p(95)=1.09ms  
     http_reqs....................................: 114325  952.685158/s
     iteration_duration...........................: avg=1.04ms   min=546.6µs med=893.1µs max=26.27ms p(90)=1.36ms   p(95)=1.57ms  
     iterations...................................: 114325  952.685158/s
     vus..........................................: 1       min=1        max=1   
     vus_max......................................: 2       min=2        max=2   

@enisdenjo enisdenjo changed the title Drop .pnpmfile.cjs because it's causing issues with renovate Drop .pnpmfile.cjs and disable NestJS Apollo Federation Compatibility action Mar 29, 2023
@enisdenjo enisdenjo marked this pull request as ready for review March 29, 2023 15:26
@enisdenjo enisdenjo merged commit b9ac3a0 into main Mar 29, 2023
@enisdenjo enisdenjo deleted the no-pnpmfile branch March 29, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant