Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update integration tests to test File.stream and File.arrayBuffer #2988

Merged
merged 3 commits into from
Sep 5, 2023

Conversation

ardatan
Copy link
Collaborator

@ardatan ardatan commented Sep 5, 2023

Instead of saving the downloaded file, now the tests are using Buffer.equals to compare the buffers(Uint8Arrays) directly.
Closes #2981

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2023

⚠️ No Changeset found

Latest commit: d91901b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}

     checks.......................................: 100.00% ✓ 356374      ✗ 0     
     data_received................................: 1.4 GB  12 MB/s
     data_sent....................................: 72 MB   599 kB/s
     http_req_blocked.............................: avg=1.46µs   min=800ns    med=1.3µs    max=751.49µs p(90)=1.9µs    p(95)=2.1µs   
     http_req_connecting..........................: avg=4ns      min=0s       med=0s       max=371.69µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=440.97µs min=206.79µs med=355.79µs max=33.57ms  p(90)=647.69µs p(95)=685.09µs
       { expected_response:true }.................: avg=440.97µs min=206.79µs med=355.79µs max=33.57ms  p(90)=647.69µs p(95)=685.09µs
     ✓ { mode:graphql-jit }.......................: avg=318.22µs min=206.79µs med=274.29µs max=20ms     p(90)=332.09µs p(95)=365.89µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=710.54µs min=562.19µs med=644.59µs max=24.71ms  p(90)=733.69µs p(95)=819.9µs 
     ✓ { mode:graphql-response-cache }............: avg=382.45µs min=263.49µs med=340.49µs max=13.99ms  p(90)=400.42µs p(95)=432.39µs
     ✓ { mode:graphql }...........................: avg=462.12µs min=326.79µs med=393.59µs max=33.57ms  p(90)=475.79µs p(95)=545.79µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 178187
     http_req_receiving...........................: avg=26.1µs   min=13.7µs   med=22.2µs   max=13.72ms  p(90)=34.7µs   p(95)=38.69µs 
     http_req_sending.............................: avg=10.9µs   min=5.5µs    med=6.8µs    max=4.41ms   p(90)=11.5µs   p(95)=14.3µs  
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=403.96µs min=183.49µs med=321.79µs max=33.08ms  p(90)=617.59µs p(95)=648.69µs
     http_reqs....................................: 178187  1484.858808/s
     iteration_duration...........................: avg=668.37µs min=397.99µs med=579.59µs max=33.98ms  p(90)=862.19µs p(95)=923.39µs
     iterations...................................: 178187  1484.858808/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

💻 Website Preview

The latest changes are available as preview in: https://6738b575.graphql-yoga.pages.dev

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2023

Apollo Federation Subgraph Compatibility Results

Federation 1 SupportFederation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

@ardatan ardatan merged commit 968eb01 into main Sep 5, 2023
26 checks passed
@ardatan ardatan deleted the add-tests-file-upload branch September 5, 2023 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File upload streaming is broken since graphql-yoga 3.5.1
1 participant