-
Notifications
You must be signed in to change notification settings - Fork 574
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use stricter typescript #3542
Conversation
|
Apollo Federation Subgraph Compatibility Results
Learn more: |
✅ Benchmark Results
|
💻 Website PreviewThe latest changes are available as preview in: https://719ce521.graphql-yoga.pages.dev |
"resolveJsonModule": true, | ||
"skipLibCheck": true, | ||
"jsx": "preserve", | ||
"exactOptionalPropertyTypes": false, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do like this one but its worth its own PR, a lot of code currently conflates this which is pretty typical with this settings when trying it out for the first time on a codebase.
@@ -5,16 +5,26 @@ import { minify as minifyT } from 'html-minifier-terser'; | |||
|
|||
const __dirname = path.dirname(fileURLToPath(import.meta.url)); | |||
|
|||
// TODO review if this function is still needed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typings might be wrong because if I remember correctly, it returns Buffer
which has toString
method that accepts an encoding type.
This comment was marked as outdated.
This comment was marked as outdated.
Awesome! Thanks 🙏 |
This PR leverages community tsconfig strict settings and updates codebase
to comply with it. All code changes are minor. Most fall into one of these
categories:
just needing a
!
to help TS).Pedantically, a patch release would be needed for affected packages. I would suggest ignoring these changes in our changelog nor making a release.