Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tutorial - Update Link.comments return type #3547

Merged
merged 11 commits into from
Dec 15, 2024
Merged

Conversation

Urigo
Copy link
Collaborator

@Urigo Urigo commented Dec 12, 2024

No description provided.

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 3351c98

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@graphql-yoga/plugin-apollo-usage-report Patch
@graphql-yoga/plugin-apq Patch
@graphql-yoga/plugin-persisted-operations Patch
graphql-yoga Patch
@graphql-yoga/nestjs Patch
@graphql-yoga/render-graphiql Patch
@graphql-yoga/plugin-apollo-inline-trace Patch
@graphql-yoga/apollo-managed-federation Patch
@graphql-yoga/plugin-csrf-prevention Patch
@graphql-yoga/plugin-defer-stream Patch
@graphql-yoga/plugin-disable-introspection Patch
@graphql-yoga/plugin-graphql-sse Patch
@graphql-yoga/plugin-jwt Patch
@graphql-yoga/plugin-prometheus Patch
@graphql-yoga/plugin-response-cache Patch
@graphql-yoga/plugin-sofa Patch
apollo-federation-gateway-with-yoga Patch
apollo-subgraph-with-yoga Patch
graphql-lambda Patch
cloudflare-advanced Patch
cloudflare Patch
nextjs-app Patch
hello-world-benchmark Patch
@graphql-yoga/nestjs-federation Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@Urigo Urigo force-pushed the tutorial-update-comments-again branch from b5484f8 to 07c0d7d Compare December 12, 2024 20:37
Copy link
Contributor

github-actions bot commented Dec 12, 2024

💻 Website Preview

The latest changes are available as preview in: https://f1bf3eda.graphql-yoga.pages.dev

Copy link
Collaborator

@EmrysMyrddin EmrysMyrddin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've pointed some little typo or rephrase, but otherwise looks good :-) Very clear !

Copy link
Collaborator

@jasonkuhrt jasonkuhrt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

website/src/pages/tutorial/basic/08-graph-relations.mdx Outdated Show resolved Hide resolved
Urigo and others added 8 commits December 15, 2024 18:24
Co-authored-by: Jason Kuhrt <jasonkuhrt@me.com>
Co-authored-by: Valentin Cocaud <v.cocaud@gmail.com>
Co-authored-by: Valentin Cocaud <v.cocaud@gmail.com>
Co-authored-by: Valentin Cocaud <v.cocaud@gmail.com>
Co-authored-by: Valentin Cocaud <v.cocaud@gmail.com>
Co-authored-by: Valentin Cocaud <v.cocaud@gmail.com>
Copy link
Contributor

Apollo Federation Subgraph Compatibility Results

Federation 1 Support Federation 2 Support
_service🟢
@key (single)🟢
@key (multi)🟢
@key (composite)🟢
repeatable @key🟢
@requires🟢
@provides🟢
federated tracing🟢
@link🟢
@shareable🟢
@tag🟢
@override🟢
@inaccessible🟢
@composeDirective🟢
@interfaceObject🟢

Learn more:

Copy link
Contributor

github-actions bot commented Dec 15, 2024

✅ Benchmark Results

     ✓ no_errors{mode:graphql}
     ✓ expected_result{mode:graphql}
     ✓ no_errors{mode:graphql-jit}
     ✓ expected_result{mode:graphql-jit}
     ✓ no_errors{mode:graphql-response-cache}
     ✓ expected_result{mode:graphql-response-cache}
     ✓ no_errors{mode:graphql-no-parse-validate-cache}
     ✓ expected_result{mode:graphql-no-parse-validate-cache}
     ✓ no_errors{mode:uws}
     ✓ expected_result{mode:uws}

     checks.......................................: 100.00% ✓ 503984      ✗ 0     
     data_received................................: 2.1 GB  14 MB/s
     data_sent....................................: 101 MB  675 kB/s
     http_req_blocked.............................: avg=1.56µs   min=1.01µs   med=1.34µs   max=275.91µs p(90)=2.06µs   p(95)=2.29µs  
     http_req_connecting..........................: avg=2ns      min=0s       med=0s       max=181.08µs p(90)=0s       p(95)=0s      
     http_req_duration............................: avg=374.28µs min=225.2µs  med=337.03µs max=15.36ms  p(90)=485.13µs p(95)=510.9µs 
       { expected_response:true }.................: avg=374.28µs min=225.2µs  med=337.03µs max=15.36ms  p(90)=485.13µs p(95)=510.9µs 
     ✓ { mode:graphql-jit }.......................: avg=303.15µs min=225.2µs  med=281.73µs max=15.36ms  p(90)=317.83µs p(95)=340.89µs
     ✓ { mode:graphql-no-parse-validate-cache }...: avg=513.94µs min=418.29µs med=484.42µs max=6.2ms    p(90)=530.71µs p(95)=635.15µs
     ✓ { mode:graphql-response-cache }............: avg=354.47µs min=265.91µs med=333.95µs max=6.71ms   p(90)=367.64µs p(95)=381.89µs
     ✓ { mode:graphql }...........................: avg=382.3µs  min=285.94µs med=349.01µs max=15.01ms  p(90)=414.81µs p(95)=495.55µs
     ✓ { mode:uws }...............................: avg=355.86µs min=276.89µs med=335.3µs  max=6.55ms   p(90)=373.79µs p(95)=399.84µs
     http_req_failed..............................: 0.00%   ✓ 0           ✗ 251992
     http_req_receiving...........................: avg=33.78µs  min=16.21µs  med=33.06µs  max=2.62ms   p(90)=40.69µs  p(95)=44.64µs 
     http_req_sending.............................: avg=8.97µs   min=5.85µs   med=7.88µs   max=333µs    p(90)=11.53µs  p(95)=12.9µs  
     http_req_tls_handshaking.....................: avg=0s       min=0s       med=0s       max=0s       p(90)=0s       p(95)=0s      
     http_req_waiting.............................: avg=331.53µs min=191.4µs  med=295.59µs max=15.21ms  p(90)=441.24µs p(95)=465.25µs
     http_reqs....................................: 251992  1679.909604/s
     iteration_duration...........................: avg=590.18µs min=399.44µs med=548.2µs  max=15.89ms  p(90)=705.28µs p(95)=737.34µs
     iterations...................................: 251992  1679.909604/s
     vus..........................................: 1       min=1         max=1   
     vus_max......................................: 2       min=2         max=2   

@Urigo Urigo merged commit 8fee214 into main Dec 15, 2024
25 checks passed
@Urigo Urigo deleted the tutorial-update-comments-again branch December 15, 2024 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants