Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug] metrics which filter by the node-exporter job don't work with Grafana Agent #48

Closed
uhthomas opened this issue May 26, 2023 · 1 comment · Fixed by #49
Closed
Assignees
Labels
bug Something isn't working released

Comments

@uhthomas
Copy link
Contributor

Describe the bug

Similar to #46, other dashboards don't work as they match against job="node-exporter". The metrics exist and I don't see a need for this label?

image

How to reproduce?

  1. Use Grafana Agent
  2. Load dashboard

Expected behavior

If I remove the label filter then it looks as expected.

image

Additional context

No response

@uhthomas uhthomas added the bug Something isn't working label May 26, 2023
uhthomas added a commit to uhthomas/grafana-dashboards-kubernetes that referenced this issue May 26, 2023
The label 'job' is not set to 'node-exporter' when using Grafan Agent, which
breaks the dashboard. There doesn't seem to be a clear reason for using the
label filter, so removing it should allow the dashboard(s) to work agnostically
across different metrics collectors.

Fixes dotdc#48
@dotdc dotdc closed this as completed in #49 May 30, 2023
@dotdc
Copy link
Owner

dotdc commented Apr 25, 2024

🎉 This issue has been resolved in version 1.1.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@dotdc dotdc added the released label Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working released
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants