Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recursively load .env files up to root #36

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

recursively load .env files up to root #36

wants to merge 1 commit into from

Conversation

ZoeyR
Copy link
Contributor

@ZoeyR ZoeyR commented Feb 4, 2020

Closes #14

@codecov
Copy link

codecov bot commented Feb 4, 2020 •
edited
Loading

Codecov Report

Merging #36 into master will increase coverage by 5.9%.
The diff coverage is 88.04%.

Impacted file tree graph

@@           Coverage Diff            @@
##           master     #36     +/-   ##
========================================
+ Coverage   77.29%   83.2%   +5.9%     
========================================
  Files          18      13      -5     
  Lines         740     387    -353     
========================================
- Hits          572     322    -250     
+ Misses        168      65    -103
Impacted Files Coverage Δ
dotenv/tests/common/mod.rs 100% <100%> (ø) ⬆️
dotenv/src/lib.rs 85.71% <100%> (-14.29%) ⬇️
dotenv/tests/test-dotenv-iter.rs 75% <60%> (-25%) ⬇️
dotenv/tests/test-from-filename-iter.rs 75% <60%> (-25%) ⬇️
dotenv/src/find.rs 93.54% <90.47%> (+0.95%) ⬆️
dotenv/src/iter.rs 92.85% <93.75%> (-3.3%) ⬇️
dotenv/src/errors.rs 9.09% <0%> (-81.39%) ⬇️
dotenv/tests/test-vars.rs
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a17dd2c...f479118. Read the comment docs.

Plecra
Plecra reviewed Jun 26, 2020
View reviewed changes
dotenv/tests/test-dotenv-iter.rs
@@ -12,11 +12,23 @@ fn test_dotenv_iter() {

let iter = dotenv_iter().unwrap();

assert!(env::var("TESTKEY").is_err());
iter.filter_map(Result::ok).any(|(key, value)| key == "TESTKEY" && value == "test_val");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this meant to be an assertion?

@andrewbanchich
Copy link

Any updates on this? I'd love to have this feature.

@ZoeyR
Copy link
Contributor Author

ZoeyR commented Sep 18, 2020

@andrewbanchich Sorry, I've been unable to work on my open source projects for a while. I should be in a place to work on them again in a few weeks.

@andrewbanchich
Copy link

Okay, no worries! Thanks for the update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Plecra Plecra Plecra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Recursively load .envs up to root
3 participants
@ZoeyR @andrewbanchich @Plecra