Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #8: Code quality #10

Merged
merged 10 commits into from
Jul 12, 2023
Merged

Issue #8: Code quality #10

merged 10 commits into from
Jul 12, 2023

Conversation

alexmerlin
Copy link
Member

No description provided.

Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
@alexmerlin alexmerlin added the enhancement New feature or request label Jul 7, 2023
@alexmerlin alexmerlin self-assigned this Jul 7, 2023
This was linked to issues Jul 7, 2023
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
@alexmerlin
Copy link
Member Author

Note:
Currently, Github action will run for PHP 8.1 only.
Once dot-twigrenderer supports PHP 8.2 as well, we can extend the actions to 8.2.

@arhimede
Copy link
Member

In this pR dotkernel/dot-twigrenderer#25
dot-twigrenderer supports 8.2

so we can release that one first

Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
Signed-off-by: alexmerlin <alex.merlin.1985@gmail.com>
@alexmerlin alexmerlin merged commit 5919f2a into 1.0 Jul 12, 2023
@alexmerlin alexmerlin deleted the issue-8 branch July 12, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

green badge Code quality
2 participants