fix/more typeahead fails #3065
Merged
fix/more typeahead fails #3065
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
henrikhorluck
commented
Nov 18, 2023
henrikhorluck
commented
- Ensure typeahead jQuery extensions are loaded
- Remove scrollspy-ing
We have at least the following jQuery versions in use:
1. `2.2.4` supplied from NPM, esbuild includes it in the chunks we later
load.
2. `2.2.4` supplied from a script-tag in (dashboard)-base (with fallback to
now defunct self-hosted static file).
- This is the "global" jQuery most of the time.
3. `3.1.1` in use in templates/dashboard/events/details.html
4. `3.2.1` for django-wiki in templates/wiki/base.html
On most of dashboard the global 2.2.4 is in use, not the one from NPM.
It appears that the typeahead library has its own way of finding out
_which_ global jQuery version it should apply to. Since esbuild is set
to output in [ESM-format](https://esbuild.github.io/api/#format-esm),
it does some transformation of CommonJs-code (module.exports), which
means that `require/module` is defined in the _browser_ (where we are running).
Is there a better way to fix this? Yes, remove the code and be in sync
around one version, or isolate them better. Is it worth using any more
time on this? No.
The two 2.2.4 are _different objects_ so you can end in a
situation where `jQuery === $` is `false`. That is what happens when these
imports are uncommented, since only the name imported is the one changed
to the NPM-supplied version.
See: 6735dda,
812c7bb, 53b57b9
There is a scrollspy function in initFrontpage.js, it appears to not be related? User-search is likely to get removed anyways.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.