Support Cognito JWT Auth in backend, remove django-oauth-toolkit #3121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are going to remove the whole SSO app, which this migration dependency hinders. I do not see why the dependency should be there in the first place?
henrikhorluck
changed the title
henrikhorluck
force-pushed
the
feat/cognito-token-auth
branch
3 times, most recently
from
eb8c7e5 to
689d60b
Compare
Hinder a later removal of django-oauth-toolkit. shop = nibble, which is now unused orderline, transactiopn and usersaldo APIs are essentially unused, some minor changes to OWF might be warranted since it might use the usersaldo API
- If the token does not exist do a fallthrough, since other auth might accept it. - If the token is expired, we should fail immediately - override the `authenticate_header` so that we keep giving 401's instead of 403's if tests, even if OidcOAuth2Auth is moved further up in the AUTH-classses
henrikhorluck
force-pushed
the
feat/cognito-token-auth
branch
from
689d60b to
056c3fe
Compare
henrikskog
approved these changes
Jan 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have verified locally that this does work with vengeful vineyard (with a patch to use Cognito as Identity provider, thus supplying a Cognito-signed JWT), and OWF using our django-oidc-provider IDP in OW4
What this breaks
It breaks all existing uses of the
/sso-based OIDC-clients authenticating towards OW4, which should be essentially no-one, since config for that was completely broken for the last couple years, anyways.This also breaks OAuth2-only uses of the same API, which I think was only used for nibble? Which is no longer in use.