Temporarily gather name data in membership page #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+10
to
+15
| {% if not user.first_name or not user.last_name %} | ||
| <div class="row"> | ||
| <div class="col-xs-12 col-sm-6 col-md-5"> | ||
| <form id="user-name-form" method="post" action="{% url 'update_user_name' %}"> | ||
| {% csrf_token %} | ||
| <h3>Vi trenger ditt fornavn og etternavn!</h3> |
There was a problem hiding this comment.
Vi trenger jo bare dette for manuell søknad—vi får det fra FEIDE ved automatisk, men nå er det krevd at det gjøres et unødvendig steg for de fleste brukere
henrikhorluck
added a commit
that referenced
this pull request
Aug 2, 2024
This reverts commit cd6f990.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Written together with @jotjern
Only show a form that asks user for first name and last name in the membership page if these fields are not present on the user.
Don't require ntnu username for searching manual approval membership